Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection options for list view layout mode #594

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Selection options for list view layout mode #594

merged 4 commits into from
Apr 14, 2020

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 14, 2020

No description provided.

@yaira2 yaira2 requested a review from lukeblevins April 14, 2020 16:10
@yaira2 yaira2 changed the base branch from master to develop April 14, 2020 16:10
lukeblevins
lukeblevins approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in the future we should make selecting/unselecting items more efficient

@yaira2 yaira2 merged commit 824ac51 into develop Apr 14, 2020
@yaira2 yaira2 deleted the SelectionOptions branch April 14, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @lukeblevins